Target vectors marshalling #4271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aliszka
force-pushed
the
named_vectors_marshalling
branch
2 times, most recently
from
afab67c
to
a94a7cf
Compare
dirkkul
previously approved these changes
Feb 20, 2024
aliszka
force-pushed
the
named_vectors_marshalling
branch
from
a94a7cf
to
dfb500e
Compare
|
parkerduckworth
approved these changes
Feb 20, 2024
dirkkul
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's being changed:
Improves the way of marshalling target vectors: splits vectors map into vectors offsets map and sequence of vector length + vector. This change would allow fetching single target vector without necessity of unmarshalling all of them
Review checklist