Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix checkpoint detection in async mode #4277

Merged
merged 7 commits into from
Feb 21, 2024
Merged

Conversation

asdine
Copy link
Member

@asdine asdine commented Feb 21, 2024

What's being changed:

This fixes the detection of checkpoints when async is enabled for the first time.

Review checklist

  • Documentation has been updated, if necessary. Link to changed documentation:
  • Chaos pipeline run or not necessary. Link to pipeline:
  • All new code is covered by tests where it is reasonable.
  • Performance tests have been run or not necessary.

@asdine asdine requested a review from abdelr February 21, 2024 09:41
abdelr
abdelr previously approved these changes Feb 21, 2024
Copy link
Contributor

@abdelr abdelr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Do we need to keep the new debug logs? Personally not against them since the level is debug. Just wondering what is the policy around it.

@asdine
Copy link
Member Author

asdine commented Feb 21, 2024

I think we can remove them, as we already have one after the preload that indicates where we started and how many vectors have been enqueued.

Copy link

sonarcloud bot commented Feb 21, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@asdine asdine requested a review from abdelr February 21, 2024 11:36
@asdine asdine merged commit c30489a into stable/v1.24 Feb 21, 2024
32 of 33 checks passed
@asdine asdine deleted the fix-checkpoint-detection branch February 21, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants