Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Async Queue(s) and VectorIndex(es) only relevant for configured legacy vector or target vectors #4279

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

aliszka
Copy link
Member

@aliszka aliszka commented Feb 21, 2024

What's being changed:

Inits and uses exclusively Shard::queue and Shard::vectorIndex OR Shard::queues and Shard::vectorIndexes depending in vectors configuration (1st for legacy vector, 2nd for target vectors).

Adds handling for queues and vector indexes that was missing previously (e.g. backup)

Review checklist

  • Documentation has been updated, if necessary. Link to changed documentation:
  • Chaos pipeline run or not necessary. Link to pipeline:
  • All new code is covered by tests where it is reasonable.
  • Performance tests have been run or not necessary.

Copy link

sonarcloud bot commented Feb 21, 2024

Quality Gate Passed Quality Gate passed

Issues
14 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@aliszka aliszka changed the title Named vectors exclusive Use Async Queue(s) and VectorIndex(es) only relevant for configured legacy vector or target vectors Feb 21, 2024
@aliszka aliszka marked this pull request as ready for review February 21, 2024 09:56
@aliszka aliszka merged commit 5422757 into stable/v1.24 Feb 21, 2024
32 of 33 checks passed
@aliszka aliszka deleted the named_vectors_exclusive branch February 21, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants