Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved class update tests #4286

Merged
merged 1 commit into from
Feb 21, 2024
Merged

Improved class update tests #4286

merged 1 commit into from
Feb 21, 2024

Conversation

aliszka
Copy link
Member

@aliszka aliszka commented Feb 21, 2024

What's being changed:

Review checklist

  • Documentation has been updated, if necessary. Link to changed documentation:
  • Chaos pipeline run or not necessary. Link to pipeline:
  • All new code is covered by tests where it is reasonable.
  • Performance tests have been run or not necessary.

@aliszka aliszka changed the base branch from master to stable/v1.24 February 21, 2024 18:09
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 21, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
6.4% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@parkerduckworth parkerduckworth merged commit 213e687 into stable/v1.24 Feb 21, 2024
31 of 33 checks passed
@parkerduckworth parkerduckworth deleted the improved_class_update_tests branch February 21, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parkerduckworth parkerduckworth parkerduckworth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aliszka @parkerduckworth