Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved update of target vector configs #4322

Merged
merged 2 commits into from
Feb 29, 2024

Conversation

aliszka
Copy link
Member

@aliszka aliszka commented Feb 26, 2024

What's being changed:

TLDR: fixes "shard is read-only" error while updating target vectors' configs.

Previously update of target vectors' configs on shard was performed for each target vector separately, starting with changing shard's state to read-only, then running update on vector index, then switching state back to ready mode.
As vector index update may be async it was undetermined when state will be set to ready again, causing update of vector index for next target vector to fail while trying to change shard's state to read-only.
Now single transition of shard's state is made. First state is changed to read-only, then updates of vector indexes of all target vectors are executed, then shard's state is changed back to ready when last (slowest) of updates finishes.

Review checklist

  • Documentation has been updated, if necessary. Link to changed documentation:
  • Chaos pipeline run or not necessary. Link to pipeline:
  • All new code is covered by tests where it is reasonable.
  • Performance tests have been run or not necessary.

@aliszka aliszka changed the base branch from master to stable/v1.24 February 26, 2024 21:26
@aliszka aliszka requested a review from a team as a code owner February 26, 2024 21:26
@aliszka aliszka force-pushed the update_vector_configs_for_shard branch 2 times, most recently from 1dc49da to 8b4136a Compare February 26, 2024 21:29
@aliszka aliszka force-pushed the update_vector_configs_for_shard branch from 8b4136a to 9020f72 Compare February 26, 2024 21:34
Copy link

sonarcloud bot commented Feb 26, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
4.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@parkerduckworth parkerduckworth merged commit cf06dbc into stable/v1.24 Feb 29, 2024
31 of 33 checks passed
@parkerduckworth parkerduckworth deleted the update_vector_configs_for_shard branch February 29, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants