Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HNSW] Only use dynamic max connections during tombstone cleanup #4326

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

trengrj
Copy link
Member

@trengrj trengrj commented Feb 27, 2024

What's being changed:

  • Improved cleaning of tombstones #4003 improved tombstone cleanup performance but had a change to the initial select neighbors heuristic for HNSW which should use M rather than the dynamic M_max (which is double at layer 0). This change reverts that change while still leaving tombstone cleanups with the larger value to improve recall.
Screenshot 2024-02-26 at 8 47 46 pm

Review checklist

  • Documentation has been updated, if necessary. Link to changed documentation:
  • Chaos pipeline run or not necessary. Link to pipeline:
  • All new code is covered by tests where it is reasonable.
  • Performance tests have been run or not necessary.

Copy link

sonarcloud bot commented Feb 27, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@weaviate-git-bot
Copy link

Great to see you again! Thanks for the contribution.

beep boop - the Weaviate bot 👋🤖

PS:
Are you already a member of the Weaviate Slack channel?

@trengrj trengrj merged commit a42c3c6 into stable/v1.24 Feb 28, 2024
32 of 33 checks passed
@trengrj trengrj deleted the trengrj/hnsw-max-connections-fix branch February 28, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants