Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix aggreagte with named vectors for non-vectorsearch ops #4331

Merged
merged 2 commits into from
Feb 27, 2024

Conversation

dirkkul
Copy link
Contributor

@dirkkul dirkkul commented Feb 27, 2024

What's being changed:

code to reproduce

agg = collection.aggregate.over_all(return_metrics=wvc.aggregate.Metrics("number").integer())
assert isinstance(agg.properties["number"], AggregateInteger)
assert agg.properties["number"].sum_ == 3
assert agg.properties["number"].minimum == 1

Review checklist

  • Documentation has been updated, if necessary. Link to changed documentation:
  • Chaos pipeline run or not necessary. Link to pipeline:
  • All new code is covered by tests where it is reasonable.
  • Performance tests have been run or not necessary.

Copy link

sonarcloud bot commented Feb 27, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@dirkkul dirkkul merged commit 0a3e3a2 into stable/v1.24 Feb 27, 2024
32 of 33 checks passed
@dirkkul dirkkul deleted the aggregate_named_vector_fix branch February 27, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants