Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix batch references to MT classes when no from class is given #4336

Merged
merged 2 commits into from
Feb 28, 2024
Merged

Fix batch references to MT classes when no from class is given #4336

merged 2 commits into from
Feb 28, 2024

Conversation

dirkkul
Copy link
Contributor

@dirkkul dirkkul commented Feb 28, 2024

What's being changed:

Fixes batch references from a non-MT class to a MT class when no "to-class" was given in the beacon and it was autodetected

Coses weaviate/weaviate-python-client#897

Review checklist

  • Documentation has been updated, if necessary. Link to changed documentation:
  • Chaos pipeline run or not necessary. Link to pipeline:
  • All new code is covered by tests where it is reasonable.
  • Performance tests have been run or not necessary.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 28, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
19.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@dirkkul dirkkul merged commit 18e1fc2 into stable/v1.24 Feb 28, 2024
31 of 33 checks passed
@dirkkul dirkkul deleted the batch_ref_to_mt_class branch February 28, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aliszka aliszka aliszka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dirkkul @aliszka