Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simd: AVX512 implementations of dot and l2 distance functions #4342

Merged
merged 10 commits into from
Mar 5, 2024

Conversation

asdine
Copy link
Member

@asdine asdine commented Feb 28, 2024

What's being changed:

This adds dedicated AVX512 SIMD functions to be used on certain processors.

Review checklist

  • Documentation has been updated, if necessary. Link to changed documentation:
  • Chaos pipeline run or not necessary. Link to pipeline:
  • All new code is covered by tests where it is reasonable.
  • Performance tests have been run or not necessary.

@asdine asdine force-pushed the as/intel-rapids branch 3 times, most recently from 8c233fa to 56a8967 Compare February 29, 2024 09:51
@asdine asdine marked this pull request as ready for review February 29, 2024 09:53
@asdine asdine changed the title WIP - intel rapids simd: AVX512 implementations of dot and l2 distance functions Feb 29, 2024
@trengrj
Copy link
Member

trengrj commented Mar 1, 2024

Nice! Could you please add some odd dimensions to TestCompareDotProductImplementations i.e. 1, 7, 33. Like in the L2 tests?

antas-marcin
antas-marcin previously approved these changes Mar 4, 2024
trengrj
trengrj previously approved these changes Mar 4, 2024
@asdine asdine changed the base branch from master to stable/v1.24 March 4, 2024 13:29
@asdine asdine dismissed stale reviews from trengrj and antas-marcin March 4, 2024 13:29

The base branch was changed.

@asdine asdine requested a review from a team as a code owner March 4, 2024 13:29
@asdine asdine changed the base branch from stable/v1.24 to master March 4, 2024 13:32
@asdine asdine changed the base branch from master to stable/v1.24 March 4, 2024 13:33
antas-marcin
antas-marcin previously approved these changes Mar 4, 2024
Copy link

sonarcloud bot commented Mar 5, 2024

Quality Gate Passed Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@antas-marcin antas-marcin merged commit a8a1fc4 into stable/v1.24 Mar 5, 2024
32 of 33 checks passed
@antas-marcin antas-marcin deleted the as/intel-rapids branch March 5, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants