Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent Schema Deadlock: Split IncomingCommit into locked/unlocked parts [backport] #4347

Merged
merged 1 commit into from
Feb 28, 2024
Merged

Prevent Schema Deadlock: Split IncomingCommit into locked/unlocked parts [backport] #4347

merged 1 commit into from
Feb 28, 2024

Conversation

parkerduckworth
Copy link
Member

What's being changed:

Backport of #4313

Review checklist

  • Documentation has been updated, if necessary. Link to changed documentation:
  • Chaos pipeline run or not necessary. Link to pipeline:
  • All new code is covered by tests where it is reasonable.
  • Performance tests have been run or not necessary.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 28, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@parkerduckworth parkerduckworth enabled auto-merge (squash) February 28, 2024 20:41
@parkerduckworth parkerduckworth merged commit 3740f87 into stable/v1.22 Feb 28, 2024
22 checks passed
@parkerduckworth parkerduckworth deleted the schema-deadlock-concurrency-gh-4312/1.22 branch February 28, 2024 21:09
jeroiraz
jeroiraz reviewed Feb 28, 2024
View reviewed changes
usecases/cluster/transactions_write.go
// TODO: only clean up on success - does this make sense?
c.Lock()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, to avoid any data race while setting the currentTransaction

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeroiraz jeroiraz jeroiraz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@parkerduckworth @jeroiraz @etiennedi