Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write Tombstones to LSM properly and handle badly formed records [backport] #4351

Merged
merged 6 commits into from
Feb 29, 2024
Merged

Write Tombstones to LSM properly and handle badly formed records [backport] #4351

merged 6 commits into from
Feb 29, 2024

Conversation

parkerduckworth
Copy link
Member

What's being changed:

Backport of #4167

Review checklist

  • Documentation has been updated, if necessary. Link to changed documentation:
  • Chaos pipeline run or not necessary. Link to pipeline:
  • All new code is covered by tests where it is reasonable.
  • Performance tests have been run or not necessary.

@weaviate-git-bot
Copy link

Great to see you again! Thanks for the contribution.

beep boop - the Weaviate bot 👋🤖

PS:
Are you already a member of the Weaviate Slack channel?

moogacs
moogacs previously approved these changes Feb 29, 2024
View reviewed changes
amourao
amourao reviewed Feb 29, 2024
View reviewed changes
Copy link
Contributor

@amourao amourao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good, we should also consider merging #4260, as otherwise, this can result in absurd amounts of logging on BM25 searches if the object state between segments got inconsistent on crash.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 29, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@parkerduckworth parkerduckworth merged commit 5dae835 into stable/v1.22 Feb 29, 2024
21 of 22 checks passed
@parkerduckworth parkerduckworth deleted the loading-bm25-bug/1.22 branch February 29, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amourao amourao amourao approved these changes

@moogacs moogacs moogacs left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@parkerduckworth @weaviate-git-bot @moogacs @amourao