Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error message for duplicated properties #4357

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

dirkkul
Copy link
Contributor

@dirkkul dirkkul commented Feb 29, 2024

What's being changed:

Old error was confusing

-		return fmt.Errorf("class %q: conflict for property %q: already in use or provided multiple times", property.Name, className)
+		return fmt.Errorf("class %q: conflict for collection %q: property %q already in use or provided multiple times", property.Name, className, strings.ToLower(property.Name))

Review checklist

  • Documentation has been updated, if necessary. Link to changed documentation:
  • Chaos pipeline run or not necessary. Link to pipeline:
  • All new code is covered by tests where it is reasonable.
  • Performance tests have been run or not necessary.

@dirkkul dirkkul force-pushed the better_error_message_duplicate_props branch from 960dfe8 to a46dd7c Compare February 29, 2024 13:36
Copy link

sonarcloud bot commented Feb 29, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@dirkkul dirkkul merged commit 10bac68 into stable/v1.24 Feb 29, 2024
32 of 33 checks passed
@dirkkul dirkkul deleted the better_error_message_duplicate_props branch February 29, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants