validates legacy vector index config when target vectors configured #4375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antas-marcin
reviewed
Mar 6, 2024
test/acceptance_with_go_client/named_vectors_tests/named_vectors_test.go
Show resolved
Hide resolved
aliszka
force-pushed
the
improve_vectorindexconfig_validation
branch
from
de33ece
to
490ec6f
Compare
aliszka
force-pushed
the
improve_vectorindexconfig_validation
branch
from
490ec6f
to
c8ef304
Compare
|
antas-marcin
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's being changed:
changes validation of class's schema in respect of legacy/named vectors:
class.vectorizer,class.vectorIndexType,class.vectorIndexType) forbidden when named vectors are configured (class.vectorConfig)class.vectorConfig[_vectorName_].vectorizer[_vectorizerName_]) and properties (property.moduleConfig[_vectorizerName_]) when named vectors are configured (class.vectorConfig)class.moduleConfigorproperty.moduleConfigare forbiddenproperty.moduleConfigvalidation on add class (previously only on add property)Review checklist