Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for multiple transformers and clip modules #4408

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

antas-marcin
Copy link
Contributor

@antas-marcin antas-marcin commented Mar 6, 2024

What's being changed:

This PR adds support for multiple transformers and clip modules. It introduces new inferenceUrl setting that can be applied in transformers and clip modules configuration examples:

"text2vec-transformers": map[string]interface{}{
    "vectorizeClassName": false,
    "inferenceUrl":       "http://custom-server-url:8080",
    "properties":         []interface{}{"prompt"},
},
"multi2vec-clip": map[string]interface{}{
    "vectorizeClassName": false,
    "inferenceUrl":       "http://192.168.0.1:9090",
    "imageFields":        []interface{}{"image"},
},

Additionally in transformers module it's also possible to configure passage and query endpoints:

"text2vec-transformers": map[string]interface{}{
    "vectorizeClassName":  false,
    "passageInferenceUrl": "http://passage-server-url:8080",
    "queryInferenceUrl":   "http://query-server-url:8080",
},

Review checklist

  • Documentation has been updated, if necessary. Link to changed documentation:
  • Chaos pipeline run or not necessary. Link to pipeline:
  • All new code is covered by tests where it is reasonable.
  • Performance tests have been run or not necessary.

@antas-marcin antas-marcin requested a review from a team as a code owner March 6, 2024 18:02
@antas-marcin antas-marcin changed the base branch from stable/v1.19 to stable/v1.24 March 6, 2024 18:02
@antas-marcin antas-marcin force-pushed the add-support-for-multiple-transformers branch from 89dee51 to 98e8b3c Compare March 6, 2024 18:06
@antas-marcin antas-marcin marked this pull request as draft March 6, 2024 21:29
@antas-marcin antas-marcin force-pushed the add-support-for-multiple-transformers branch 3 times, most recently from 5dc1f0b to e631d13 Compare March 7, 2024 10:05
@antas-marcin antas-marcin changed the title Add support for multiple transformers Add support for multiple transformers and clip modules Mar 7, 2024
@antas-marcin antas-marcin force-pushed the add-support-for-multiple-transformers branch from e631d13 to 679f3a6 Compare March 9, 2024 09:49
@antas-marcin antas-marcin force-pushed the add-support-for-multiple-transformers branch from 679f3a6 to 75c6141 Compare March 9, 2024 11:17
Copy link

sonarcloud bot commented Mar 9, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
23.2% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@antas-marcin antas-marcin marked this pull request as ready for review March 9, 2024 11:30
@antas-marcin antas-marcin merged commit 5a13439 into stable/v1.24 Mar 11, 2024
34 of 36 checks passed
@antas-marcin antas-marcin deleted the add-support-for-multiple-transformers branch March 11, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants