No force shard loading for nodes status API #4424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Great to see you again! Thanks for the contribution. |
dirkkul
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's being changed:
Due to the unpredictable number of methods added to
LazyLoadShard's and their usage in the nodes status API, we should never attempt to fulfill a full shard status for an unloaded shard. The background here is that the nodes status API will range over all shards in each index, force loading them all in parallel, totally defeating the purpose of the lazy load feature.Instead, the shard name, class, and queue status can still be returned without loading, alongside a new boolean
Loadedfield in the nodes status response, indicating that the shard is not yet loaded.Review checklist