Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protecting the cleanup from concurrent use with the compression #4439

Conversation

abdelr
Copy link
Contributor

@abdelr abdelr commented Mar 8, 2024

What's being changed:

Compression and tombstone cleanup should not happen concurrently. This PR protects the code from concurrent use. It also fixes #4427

Review checklist

  • Documentation has been updated, if necessary. Link to changed documentation:
  • Chaos pipeline run or not necessary. Link to pipeline:
  • All new code is covered by tests where it is reasonable.
  • Performance tests have been run or not necessary.

@abdelr abdelr self-assigned this Mar 8, 2024
@abdelr abdelr linked an issue Mar 8, 2024 that may be closed by this pull request
1 task
Copy link

sonarcloud bot commented Mar 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@antas-marcin antas-marcin merged commit f34d1f9 into stable/v1.24 Mar 11, 2024
34 of 35 checks passed
@antas-marcin antas-marcin deleted the Fixing-panic-when-compression-in-the-middle-of-a-cleanup branch March 11, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

segmentation violation panic with deletion concurrency > 1
3 participants