Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cardinality issues for backup-related metrics (v1.24.x) #4443

Merged
merged 2 commits into from
Mar 11, 2024

Conversation

etiennedi
Copy link
Member

What's being changed:

  • add backups to metrics cardinality tests
  • test is now red
  • fix cardinality issues for bucket pause, backup store and backup restore metrics
  • test is now green

fixes #4442

Review checklist

  • Documentation has been updated, if necessary. Link to changed documentation:
  • Chaos pipeline run or not necessary. Link to pipeline:
  • All new code is covered by tests where it is reasonable.
  • Performance tests have been run or not necessary.

- add backups to metrics cardinality tests
- test is now red
- fix cardinality issues for bucket pause, backup store and backup
  restore metrics
- test is now green

fixes #4442
@etiennedi etiennedi changed the title gh-4442 extend test suite, fix cardinality for backup related metrics Fix cardinality issues for backup-related metrics Mar 11, 2024
@etiennedi etiennedi changed the title Fix cardinality issues for backup-related metrics Fix cardinality issues for backup-related metrics (v1.24.x) Mar 11, 2024
Copy link

sonarcloud bot commented Mar 11, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@etiennedi etiennedi merged commit 9a6ae5d into stable/v1.24 Mar 11, 2024
36 checks passed
@etiennedi etiennedi deleted the fix-backup-metric-not-respecting-grouping branch March 11, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants