Fix unit tests in VoyageAI module #4451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* 1st step: Blind find-replace * 2nd step: Now it compiles and the tests run smootly * Further changes (correct request and response objects, define available models, etc.), but the tests are broken * /v1 to default URL * Formatting for GH Actions * Steps mentioned in Slack: Hey @hong Liu and @fődi, Zoltán , could you please either run these commands as @dirk describes above, requiring: Just run from the weaviate root ./tools/gen-code-from-swagger.sh This just adds the \\\ \\ Weaviate styling to 4 of the files. 2. You can download this with go install mvdan.cc/gofumpt@latest check the installation with: gofumpt -h And then you are all set as Dirk describes with gofumpt -w . I am not sure what the next steps will be, I will keep an eye out on the refactor. * Steps mentioned in Slack: Hey @hong Liu and @fődi, Zoltán , could you please either run these commands as @dirk describes above, requiring: Just run from the weaviate root ./tools/gen-code-from-swagger.sh This just adds the \\\ \\ Weaviate styling to 4 of the files. 2. You can download this with go install mvdan.cc/gofumpt@latest check the installation with: gofumpt -h And then you are all set as Dirk describes with gofumpt -w . I am not sure what the next steps will be, I will keep an eye out on the refactor. * Steps mentioned in Slack: Hey @hong Liu and @fődi, Zoltán , could you please either run these commands as @dirk describes above, requiring: Just run from the weaviate root ./tools/gen-code-from-swagger.sh This just adds the \\\ \\ Weaviate styling to 4 of the files. 2. You can download this with go install mvdan.cc/gofumpt@latest check the installation with: gofumpt -h And then you are all set as Dirk describes with gofumpt -w . I am not sure what the next steps will be, I will keep an eye out on the refactor. * Adding X-Voyageai... headers * Correcting X-VoyageAI... headers (to X-Voyageai...) * Reverting the named_vectors_... files changes * here you can leave a nice form X-VoyageAI-Api-Key * Reverting * Correcting the URL * Correcting the document input type --------- Co-authored-by: fodizoltan <zoltan@conway.expert> Co-authored-by: Connor Shorten <connorshorten300@gmail.com>
|
aliszka
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's being changed:
This PR adds new
VoyageAImodule.Review checklist