Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update text2vec-voyageai truncate setting from string to bool type #4458

Merged
merged 1 commit into from
Mar 12, 2024
Merged

Update text2vec-voyageai truncate setting from string to bool type #4458

merged 1 commit into from
Mar 12, 2024

Conversation

antas-marcin
Copy link
Contributor

What's being changed:

This PR changes the truncate type setting from string to bool.

Review checklist

  • Documentation has been updated, if necessary. Link to changed documentation:
  • Chaos pipeline run or not necessary. Link to pipeline:
  • All new code is covered by tests where it is reasonable.
  • Performance tests have been run or not necessary.

@antas-marcin antas-marcin force-pushed the fix-truncate-setting-in-voyageai-module branch from e70fcf8 to 3bda498 Compare March 12, 2024 16:32
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 12, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@antas-marcin antas-marcin merged commit 2953c43 into stable/v1.24 Mar 12, 2024
34 of 36 checks passed
@antas-marcin antas-marcin deleted the fix-truncate-setting-in-voyageai-module branch March 12, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aliszka aliszka aliszka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@antas-marcin @aliszka