Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specialize voter nodes for metadata storage #4734

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

redouan-rhazouani
Copy link
Contributor

Improve performance of voter nodes by specializing them in storing metadata only.
Introduce a cluster-wide flag: when set, serving nodes do not schedule shards or tenants on voters, reducing their responsibilities to focus on schema and metadata

What's being changed:

Review checklist

  • Documentation has been updated, if necessary. Link to changed documentation:
  • Chaos pipeline run or not necessary. Link to pipeline:
  • All new code is covered by tests where it is reasonable.
  • Performance tests have been run or not necessary.

@redouan-rhazouani redouan-rhazouani force-pushed the feature/voters_as_meta_nodes branch 2 times, most recently from 49b4594 to 4438a19 Compare April 22, 2024 07:36
@redouan-rhazouani redouan-rhazouani marked this pull request as ready for review April 22, 2024 09:23
 Introduce cluster-wide flag to exclude shards/tenants on voters
Copy link

sonarcloud bot commented Apr 25, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@jfrancoa jfrancoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No objections from my side, but I would prefer if @moogacs or @reyreaud-l approve it.

@antas-marcin antas-marcin merged commit fdb2b6d into main Apr 25, 2024
41 checks passed
@antas-marcin antas-marcin deleted the feature/voters_as_meta_nodes branch April 25, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants