Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make batch operation retrieve and pass schema version to client #4738

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

reyreaud-l
Copy link
Contributor

@reyreaud-l reyreaud-l commented Apr 22, 2024

What's being changed:

Update the following batch endpoints to retrieve schema version from schema reads and propagate it to the other replicas

  • Batch write
  • Batch delete
  • Batch add ref

Review checklist

  • Documentation has been updated, if necessary. Link to changed documentation:
  • Chaos pipeline run or not necessary. Link to pipeline:
  • All new code is covered by tests where it is reasonable.
  • Performance tests have been run or not necessary.

moogacs
moogacs previously approved these changes Apr 22, 2024
@reyreaud-l reyreaud-l force-pushed the lre/send-schema-version-add-batch branch from c5357a9 to 6572155 Compare April 22, 2024 16:34
@reyreaud-l reyreaud-l requested a review from moogacs April 22, 2024 16:34
@reyreaud-l reyreaud-l changed the title make add batch get and send the schema version to replicas make batch operation retrieve and pass schema version to client Apr 22, 2024
@reyreaud-l reyreaud-l force-pushed the lre/send-schema-version-add-batch branch 2 times, most recently from 7408f53 to 5ed911e Compare April 22, 2024 16:43
Signed-off-by: Loic Reyreaud <loic@weaviate.io>
Copy link

sonarcloud bot commented Apr 22, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@reyreaud-l reyreaud-l merged commit 008cee7 into main Apr 23, 2024
41 checks passed
@reyreaud-l reyreaud-l deleted the lre/send-schema-version-add-batch branch April 23, 2024 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants