Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the schema version parsing to not always return 0 #4767

Merged
merged 1 commit into from
Apr 25, 2024
Merged

Update the schema version parsing to not always return 0 #4767

merged 1 commit into from
Apr 25, 2024

Conversation

reyreaud-l
Copy link
Contributor

What's being changed:

  • Replicas node never consider the schema version sent from coordinator because the parsing function would always return 0

Review checklist

  • Documentation has been updated, if necessary. Link to changed documentation:
  • Chaos pipeline run or not necessary. Link to pipeline:
  • All new code is covered by tests where it is reasonable.
  • Performance tests have been run or not necessary.

aliszka
aliszka previously approved these changes Apr 25, 2024
View reviewed changes
moogacs
moogacs previously approved these changes Apr 25, 2024
View reviewed changes
@reyreaud-l
Update the schema version parsing to not always return 0
2d62cbc 
Signed-off-by: Loic Reyreaud <loic@weaviate.io>
@reyreaud-l reyreaud-l dismissed stale reviews from moogacs and aliszka via 2d62cbc April 25, 2024 15:27
@reyreaud-l reyreaud-l force-pushed the lre/fix-schema-version-parsing branch from 32d8fe9 to 2d62cbc Compare April 25, 2024 15:27
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 25, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@reyreaud-l reyreaud-l merged commit df2a66f into main Apr 25, 2024
40 checks passed
@reyreaud-l reyreaud-l deleted the lre/fix-schema-version-parsing branch April 25, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moogacs moogacs moogacs approved these changes

@aliszka aliszka Awaiting requested review from aliszka

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@reyreaud-l @aliszka @moogacs