Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve input validation of ID in nearObject and vector in nearVector #4782

Merged
merged 2 commits into from
Apr 29, 2024
Merged

Improve input validation of ID in nearObject and vector in nearVector #4782

merged 2 commits into from
Apr 29, 2024

Conversation

tsmith023
Copy link
Contributor

What's being changed:

This PR adds validation for empty nearObejct.Id and nearVector.Vector to catch erroneous client input

Review checklist

  • Documentation has been updated, if necessary. Link to changed documentation:
  • Chaos pipeline run or not necessary. Link to pipeline:
  • All new code is covered by tests where it is reasonable.
  • Performance tests have been run or not necessary.

@tsmith023 tsmith023 requested a review from dirkkul April 27, 2024 12:56
@tsmith023 tsmith023 merged commit a2aba1d into stable/v1.24 Apr 29, 2024
38 checks passed
@tsmith023 tsmith023 deleted the grpc/improve-input-validation-of-near-searches branch April 29, 2024 14:27
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 29, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
D Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antas-marcin antas-marcin antas-marcin approved these changes

@dirkkul dirkkul Awaiting requested review from dirkkul

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tsmith023 @antas-marcin