Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make coordinator node wait for schema version if changed on validate step #4794

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

reyreaud-l
Copy link
Contributor

What's being changed:

Ensures that the coordinator node on writes will wait for the schema version to have propagated locally. This is necessary to be sure that any related DB changes (buckets, indexes, etc...) that are instantiated by auto schema/tenants are present on the node before we proceed with the write operation.

Review checklist

  • Documentation has been updated, if necessary. Link to changed documentation:
  • Chaos pipeline run or not necessary. Link to pipeline:
  • All new code is covered by tests where it is reasonable.
  • Performance tests have been run or not necessary.

…step

Signed-off-by: Loic Reyreaud <loic@weaviate.io>
@reyreaud-l reyreaud-l force-pushed the lre/fix-EC-coordinator-wait-for-version branch from 9b67fe1 to a4fdf47 Compare April 29, 2024 11:55
Copy link

sonarcloud bot commented Apr 29, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@moogacs moogacs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, :shipit:

@reyreaud-l reyreaud-l merged commit 90194be into main Apr 29, 2024
41 checks passed
@reyreaud-l reyreaud-l deleted the lre/fix-EC-coordinator-wait-for-version branch April 29, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants