Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Schema v2 prevent shutdown #4821

Merged
merged 3 commits into from
May 2, 2024
Merged

Schema v2 prevent shutdown #4821

merged 3 commits into from
May 2, 2024

Conversation

aliszka
Copy link
Member

@aliszka aliszka commented May 2, 2024

What's being changed:

Adds locks to prevent concurrent shard usage (handling requests) and shutdown

Review checklist

  • Documentation has been updated, if necessary. Link to changed documentation:
  • Chaos pipeline run or not necessary. Link to pipeline:
  • All new code is covered by tests where it is reasonable.
  • Performance tests have been run or not necessary.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 2, 2024

Quality Gate Passed Quality Gate passed

Issues
8 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@aliszka aliszka marked this pull request as ready for review May 2, 2024 12:50
moogacs
moogacs reviewed May 2, 2024
View reviewed changes
adapters/repos/db/shard.go Show resolved Hide resolved
adapters/repos/db/shard.go Show resolved Hide resolved
jeroiraz
jeroiraz approved these changes May 2, 2024
View reviewed changes
Copy link
Contributor

@jeroiraz jeroiraz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM only left the same comment over and over in different places to avoid hiding an error and kept consistency when the same function is called as in same places the original error is returned

@moogacs
Copy link
Contributor

moogacs commented May 2, 2024

LGTM, we can revisit in later on iteration to address comments to unblock the release while it's well tested

@moogacs moogacs enabled auto-merge May 2, 2024 15:13
@moogacs moogacs merged commit 85b15fb into main May 2, 2024
40 of 41 checks passed
@moogacs moogacs deleted the schemaV2_prevent_shutdown branch May 2, 2024 15:15
@moogacs moogacs mentioned this pull request May 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moogacs moogacs moogacs approved these changes

@jeroiraz jeroiraz jeroiraz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aliszka @moogacs @jeroiraz