Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change modelId setting to model in Ollama modules #4870

Merged
merged 1 commit into from
May 7, 2024
Merged

Change modelId setting to model in Ollama modules #4870

merged 1 commit into from
May 7, 2024

Conversation

antas-marcin
Copy link
Contributor

What's being changed:

Changed modelId to model in generative-ollama and tex2vec-ollama modules.

Review checklist

  • Documentation has been updated, if necessary. Link to changed documentation:
  • Chaos pipeline run or not necessary. Link to pipeline:
  • All new code is covered by tests where it is reasonable.
  • Performance tests have been run or not necessary.

@antas-marcin antas-marcin force-pushed the change-modelid-to-model-in-ollama-modules branch from 5df9f3b to 13bf814 Compare May 7, 2024 19:20
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@dirkkul dirkkul merged commit a47564b into stable/v1.25 May 7, 2024
42 checks passed
@dirkkul dirkkul deleted the change-modelid-to-model-in-ollama-modules branch May 7, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dirkkul dirkkul dirkkul approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@antas-marcin @dirkkul