make bootstrap exit early on RAFT store reporting ready #4871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reyreaud-l
force-pushed
the
lre/fix-bootstrap-timeout-restart
branch
from
45216b1
to
3e19b1e
Compare
antas-marcin
previously approved these changes
May 8, 2024
moogacs
reviewed
May 8, 2024
reyreaud-l
force-pushed
the
lre/fix-bootstrap-timeout-restart
branch
from
3e19b1e
to
a9ebe84
Compare
reyreaud-l
force-pushed
the
lre/fix-bootstrap-timeout-restart
branch
2 times, most recently
from
9a6f169
to
2200a77
Compare
reyreaud-l
changed the title
reyreaud-l
force-pushed
the
lre/fix-bootstrap-timeout-restart
branch
from
2200a77
to
0e7e616
Compare
Signed-off-by: Loic Reyreaud <loic@weaviate.io>
reyreaud-l
force-pushed
the
lre/fix-bootstrap-timeout-restart
branch
from
0e7e616
to
fa83fd2
Compare
|
moogacs
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's being changed:
Our current bootstrap routine doesn't return if the cluster recovers from the RAFT log config. Due to that the bootstrap process will be in a fail loop where it tries to join and is denied due to being already a member of the cluster.
Once we hit the timeout the node would crash and restart.
Change the bootstrap process to check for the RAFT store reporting ready, meaning we have joined a cluster and the bootstrap can stop.
Also improve logs to have the common
actionfield and be more explicit on failure/success.Review checklist