Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raft: reserve raft as a class name #4874

Merged
merged 3 commits into from
May 8, 2024
Merged

Conversation

moogacs
Copy link
Contributor

@moogacs moogacs commented May 8, 2024

What's being changed:

Review checklist

  • Documentation has been updated, if necessary. Link to changed documentation:
  • Chaos pipeline run or not necessary. Link to pipeline:
  • All new code is covered by tests where it is reasonable.
  • Performance tests have been run or not necessary.

reyreaud-l
reyreaud-l previously approved these changes May 8, 2024
Copy link

sonarcloud bot commented May 8, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
54.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Copy link
Contributor

@reyreaud-l reyreaud-l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@moogacs moogacs merged commit 18e100e into stable/v1.25 May 8, 2024
41 of 42 checks passed
@moogacs moogacs deleted the reser-raft-class-name branch May 8, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants