Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix generative-aws module, add support for all Bedrock models #4918

Merged
merged 1 commit into from
May 14, 2024
Merged

Fix generative-aws module, add support for all Bedrock models #4918

merged 1 commit into from
May 14, 2024

Conversation

antas-marcin
Copy link
Contributor

What's being changed:

Fix generative-aws module, add support for all Bedrock models

Review checklist

  • Documentation has been updated, if necessary. Link to changed documentation:
  • Chaos pipeline run or not necessary. Link to pipeline:
  • All new code is covered by tests where it is reasonable.
  • Performance tests have been run or not necessary.

@antas-marcin antas-marcin force-pushed the fix-generative-aws-module branch 3 times, most recently from 9f4ff56 to 4e06440 Compare May 14, 2024 14:21
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 14, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
17.6% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@antas-marcin antas-marcin merged commit 4fb8881 into stable/v1.24 May 14, 2024
33 of 34 checks passed
@antas-marcin antas-marcin deleted the fix-generative-aws-module branch May 14, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parkerduckworth parkerduckworth parkerduckworth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@antas-marcin @parkerduckworth