-
Notifications
You must be signed in to change notification settings - Fork 686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RAFT: fix race between apply for classes in the schema and report ready only after db reloaded #4946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reyreaud-l
reviewed
May 16, 2024
reyreaud-l
previously approved these changes
May 16, 2024
357f49c
to
18af693
Compare
3b7ec4e
to
685f396
Compare
4094264
to
f2689d4
Compare
|
antas-marcin
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's being changed:
this PR add a fix to handle data races on accessing the schema classes
st.db.Schema.Classes
those situation can happen if there is concurrent apply at the same time and in this change we reload the db from introduced new func
reloadDBFromSchema()
which serialize access to schema classesalso convert
dbLoaded
flag to be set inreloadDBFromSchema()
func only given that flag is used to report ready and in case of recovering we need to reload the db before reporting ready to have the consistent state forquery
Review checklist