Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bezier timing function values in WAN seem to be different from those in Blink #139

Closed
rjwright opened this issue Aug 11, 2014 · 0 comments · Fixed by #428
Closed

Bezier timing function values in WAN seem to be different from those in Blink #139

rjwright opened this issue Aug 11, 2014 · 0 comments · Fixed by #428
Assignees
@rjwright
Labels
bug web-animations-1

Comments

@rjwright
Copy link
Contributor

WAN cubic bezier code is in animation-node.js.

I noticed the difference when making the test for #136.

Needs to be verified.
@rjwright rjwright self-assigned this Aug 11, 2014
ericwilligers added a commit to ericwilligers/web-animations-next that referenced this issue Apr 18, 2016
@ericwilligers
Increase Bezier timing function accuracy
1b2f076 
The polyfill evaluation of cubic Bezier timing functions
gives slightly different results than the native Blink
implementation.

In my testing, this change reduced the absolute error by 63%
while only increasing the number of cubic function evaluations
by 31%

This closes web-animations#139
@ericwilligers ericwilligers mentioned this issue Apr 18, 2016
Merged
ericwilligers added a commit to ericwilligers/web-animations-next that referenced this issue Apr 21, 2016
@ericwilligers
Increase Bezier timing function accuracy
83c9090 
The polyfill evaluation of cubic Bezier timing functions
gives slightly different results than the native Blink
implementation.

In my testing, this change reduced the absolute error by 63%
while only increasing the number of cubic function evaluations
by 31%

This closes web-animations#139
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rjwright rjwright

Labels
bug web-animations-1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Increase Bezier timing function accuracy ericwilligers/web-animations-next
2 participants
@shans @rjwright