Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid updating all animation effects on single animation mutation #485

Merged
merged 5 commits into from Aug 3, 2016
Merged

Avoid updating all animation effects on single animation mutation #485

merged 5 commits into from Aug 3, 2016

Conversation

alancutter
Copy link
Contributor

This change avoids applying the effects of all Animations when a single Animation's state is modified (e.g. setting currentTime).
This is particularly effective

Performance numbers on Firefox Nightly:
500 calls to element.animate(null, 1000): 1600ms down to 170ms.
The 500 Individual Stars demo (rewritten to use element.animate()): 8.5-9.5s down to 4.5-5s
Test case in #472: 2.5-4s down to 30-50ms

@ewilligers
Copy link
Contributor

lgtm

@suzyh suzyh merged commit fbb1a15 into web-animations:master Aug 3, 2016
@alancutter
Copy link
Contributor Author

I discovered afterwards that the quoted performance numbers in the description are a bit bogus. Turns out Firefox's performance is heavily influenced by the developer console being open which I was not accounting for.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants