Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.gitattributes into sub repos #71

Closed
reedy opened this issue Jul 31, 2019 · 2 comments
Closed

.gitattributes into sub repos #71

reedy opened this issue Jul 31, 2019 · 2 comments

Comments

@reedy
Copy link

reedy commented Jul 31, 2019

Hello!

I notice there is a .gitattributes file in this repo, which is great, but it doesn't seem to get included into sub repos such as webauthn-lib and cose-lib.

This means when they're installed via composer, the various root and dot files still exist in those repos, losing the benefits of the .gitattributes file

I don't know how your build processes work, as such, how code ends up in those "readonly" repos... But if you could include .gitattributes in the files that are copied/pushed across, that'd be really helpful

Thanks!

└── web-auth
    ├── cose-lib
    │   ├── composer.json
    │   ├── LICENSE
    │   ├── phpunit.xml.dist
    │   ├── README.md
    │   ├── src
    │   │   ├── Algorithm
    │   │   │   ├── Algorithm.php
    │   │   │   ├── Mac
    │   │   │   │   ├── Hmac.php
    │   │   │   │   ├── HS256.php
    │   │   │   │   ├── HS256Truncated64.php
    │   │   │   │   ├── HS384.php
    │   │   │   │   ├── HS512.php
    │   │   │   │   └── Mac.php
    │   │   │   ├── Manager.php
    │   │   │   └── Signature
    │   │   │       ├── ECDSA
    │   │   │       │   ├── ECDSA.php
    │   │   │       │   ├── ES256.php
    │   │   │       │   ├── ES384.php
    │   │   │       │   └── ES512.php
    │   │   │       ├── EdDSA
    │   │   │       │   └── EdDSA.php
    │   │   │       ├── RSA
    │   │   │       │   ├── PS256.php
    │   │   │       │   ├── PS384.php
    │   │   │       │   ├── PS512.php
    │   │   │       │   ├── PSSRSA.php
    │   │   │       │   ├── RS1.php
    │   │   │       │   ├── RS256.php
    │   │   │       │   ├── RS384.php
    │   │   │       │   ├── RS512.php
    │   │   │       │   └── RSA.php
    │   │   │       └── Signature.php
    │   │   ├── Algorithms.php
    │   │   ├── Key
    │   │   │   ├── Ec2Key.php
    │   │   │   ├── Key.php
    │   │   │   ├── OkpKey.php
    │   │   │   ├── RsaKey.php
    │   │   │   └── SymmetricKey.php
    │   │   └── Verifier.php
    │   └── tests
    │       └── unit
    │           └── Signature
    │               ├── RSA15SignatureTest.php
    │               └── RSAPSSSignatureTest.php
    └── webauthn-lib
        ├── composer.json
        ├── LICENSE
        ├── phpunit.xml.dist
        ├── README.md
        ├── src
        │   ├── AttestationStatement
        │   │   ├── AndroidKeyAttestationStatementSupport.php
        │   │   ├── AndroidSafetyNetAttestationStatementSupport.php
        │   │   ├── AttestationObjectLoader.php
        │   │   ├── AttestationObject.php
        │   │   ├── AttestationStatement.php
        │   │   ├── AttestationStatementSupportManager.php
        │   │   ├── AttestationStatementSupport.php
        │   │   ├── FidoU2FAttestationStatementSupport.php
        │   │   ├── NoneAttestationStatementSupport.php
        │   │   ├── PackedAttestationStatementSupport.php
        │   │   └── TPMAttestationStatementSupport.php
        │   ├── AttestedCredentialData.php
        │   ├── AuthenticationExtensions
        │   │   ├── AuthenticationExtension.php
        │   │   ├── AuthenticationExtensionsClientInputs.php
        │   │   ├── AuthenticationExtensionsClientOutputsLoader.php
        │   │   ├── AuthenticationExtensionsClientOutputs.php
        │   │   ├── ExtensionOutputCheckerHandler.php
        │   │   ├── ExtensionOutputChecker.php
        │   │   └── ExtensionOutputError.php
        │   ├── AuthenticatorAssertionResponse.php
        │   ├── AuthenticatorAssertionResponseValidator.php
        │   ├── AuthenticatorAttestationResponse.php
        │   ├── AuthenticatorAttestationResponseValidator.php
        │   ├── AuthenticatorData.php
        │   ├── AuthenticatorResponse.php
        │   ├── AuthenticatorSelectionCriteria.php
        │   ├── CertificateToolbox.php
        │   ├── CollectedClientData.php
        │   ├── Credential.php
        │   ├── PublicKeyCredentialCreationOptions.php
        │   ├── PublicKeyCredentialDescriptorCollection.php
        │   ├── PublicKeyCredentialDescriptor.php
        │   ├── PublicKeyCredentialEntity.php
        │   ├── PublicKeyCredentialLoader.php
        │   ├── PublicKeyCredentialParameters.php
        │   ├── PublicKeyCredential.php
        │   ├── PublicKeyCredentialRequestOptions.php
        │   ├── PublicKeyCredentialRpEntity.php
        │   ├── PublicKeyCredentialSource.php
        │   ├── PublicKeyCredentialSourceRepository.php
        │   ├── PublicKeyCredentialUserEntity.php
        │   ├── TokenBinding
        │   │   ├── IgnoreTokenBindingHandler.php
        │   │   ├── TokenBindingHandler.php
        │   │   ├── TokenBindingNotSupportedHandler.php
        │   │   └── TokenBinding.php
        │   └── TrustPath
        │       ├── CertificateTrustPath.php
        │       ├── EcdaaKeyIdTrustPath.php
        │       ├── EmptyTrustPath.php
        │       ├── TrustPathLoader.php
        │       └── TrustPath.php
        └── tests
            ├── certificates
            │   ├── chain
            │   │   ├── 1.crt
            │   │   ├── 1.der
            │   │   ├── 2.crt
            │   │   ├── 2.der
            │   │   ├── 3.crt
            │   │   ├── 3.der
            │   │   ├── 4.crt
            │   │   └── 4.der
            │   ├── frank4dd-cacert.crt
            │   └── yubico.crt
            ├── functional
            │   ├── AbstractTestCase.php
            │   ├── AndroidKeyAttestationStatementTest.php
            │   ├── AndroidSafetyNetAttestationStatementTest.php
            │   ├── AssertionTest.php
            │   ├── AttestationStatementWithTokenBindingTest.php
            │   ├── Fido2AttestationStatementTest.php
            │   ├── NoneAttestationStatementTest.php
            │   ├── PackedAttestationStatementTest.php
            │   ├── SubDomainRelyingPartyTest.php
            │   ├── TPMAttestationStatementTest.php
            │   └── W10Test.php
            └── unit
                ├── AttestationStatement
                │   ├── AndroidKeyAttestationStatementSupportTest.php
                │   ├── AttestationObjectTest.php
                │   ├── AttestationStatementSupportManagerTest.php
                │   ├── AttestationStatementTest.php
                │   ├── FidoU2FAttestationStatementSupportTest.php
                │   └── NoneAttestationStatementSupportTest.php
                ├── AttestedCredentialDataTest.php
                ├── AuthenticationExtensions
                │   ├── AuthenticationExtensionsClientOutputsLoaderTest.php
                │   └── AuthenticationExtensionsClientTest.php
                ├── AuthenticatorAssertionResponseTest.php
                ├── AuthenticatorAttestationResponseTest.php
                ├── AuthenticatorDataTest.php
                ├── AuthenticatorSelectionCriteriaTest.php
                ├── CertificateChainCheckerTest.php
                ├── CollectedClientDataTest.php
                ├── EntityTest.php
                ├── PublicKeyCredentialCreationOptionsTest.php
                ├── PublicKeyCredentialDescriptorTest.php
                ├── PublicKeyCredentialParametersTest.php
                ├── PublicKeyCredentialRequestOptionsTest.php
                ├── TokenBindingTest.php
                └── TrustPath
                    ├── FooTrustPath.php
                    ├── NotAValidTrustPath.php
                    └── TrustPathTest.php
@Spomky
Copy link
Contributor

Spomky commented Aug 10, 2019

Done in e3ae5aa.
Will be part on the next minor version (v2.1)

@github-actions
Copy link
Contributor

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants