Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.github in .gitattributes hasn't worked #90

Closed
reedy opened this issue Sep 3, 2019 · 1 comment · Fixed by #91
Closed

.github in .gitattributes hasn't worked #90

reedy opened this issue Sep 3, 2019 · 1 comment · Fixed by #91

Comments

@reedy
Copy link

reedy commented Sep 3, 2019

Thanks for the updates to .gitattributes amongst your repositories (#71), much appreciated

It seems the addition of .github hasn't actually worked correctly, and we're still getting the .github folder in the different libraries

I'm guessing it's the lack of export-ignore after the github lines, and I guess the same for the docs and tests lines too

reedy@ubuntu64-web-esxi:~/composer-test$ composer require web-auth/cose-lib v2.1.5
./composer.json has been created
Loading composer repositories with package information
Updating dependencies (including require-dev)
Package operations: 3 installs, 0 updates, 0 removals
  - Installing beberlei/assert (v3.2.3): Loading from cache
  - Installing fgrosse/phpasn1 (v2.1.1): Loading from cache
  - Installing web-auth/cose-lib (v2.1.5): Loading from cache
fgrosse/phpasn1 suggests installing php-curl (For loading OID information from the web if they have not bee defined statically)
Writing lock file
Generating autoload files 
reedy@ubuntu64-web-esxi:~/composer-test$ ls -al vendor/web-auth/cose-lib/
total 32
drwxrwxr-x 5 reedy reedy 4096 Sep  3 13:11 .
drwxrwxr-x 3 reedy reedy 4096 Sep  3 13:11 ..
-rw-rw-r-- 1 reedy reedy 1116 Sep  2 21:01 composer.json
drwxrwxr-x 2 reedy reedy 4096 Sep  2 21:01 .github
-rw-rw-r-- 1 reedy reedy 1068 Sep  2 21:01 LICENSE
-rw-rw-r-- 1 reedy reedy 1130 Sep  2 21:01 README.md
drwxrwxr-x 4 reedy reedy 4096 Sep  2 21:01 src
drwxrwxr-x 3 reedy reedy 4096 Sep  2 21:01 tests
reedy@ubuntu64-web-esxi:~/composer-test$ ls -al vendor/web-auth/cose-lib/.github/
total 20
drwxrwxr-x 2 reedy reedy 4096 Sep  2 21:01 .
drwxrwxr-x 5 reedy reedy 4096 Sep  3 13:11 ..
-rw-rw-r-- 1 reedy reedy  224 Sep  2 21:01 CONTRIBUTING.md
-rw-rw-r-- 1 reedy reedy   25 Sep  2 21:01 FUNDING.yml
-rw-rw-r-- 1 reedy reedy  160 Sep  2 21:01 PULL_REQUEST_TEMPLATE.md
reedy added a commit to reedy/webauthn-framework that referenced this issue Sep 3, 2019
@Spomky Spomky closed this as completed in #91 Sep 3, 2019
@github-actions
Copy link
Contributor

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant