Previous fix for eddsa key fail at authentication #449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes web-auth#448 Previously added for issue web-auth#436, the field kty must be text string or int but not byte string (rfc8152 section 7)
|
Good catch ! |
|
Is it possible to have the options and authenticator response to add a test and avoid regression ? |
|
Many thanks for the test case. |
|
When did you have planned to release the 4.7.x? Is it possible to have these changes into 4.6.5? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously added for issue #436, the field kty (1) must be text string or int but not byte string (rfc8152 section 7)
Target branch:
Resolves issue #448