Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix class-string extend issue #490

Merged
merged 1 commit into from
Sep 29, 2023
Merged

Fix class-string extend issue #490

merged 1 commit into from
Sep 29, 2023

Conversation

Spomky
Copy link
Contributor

@Spomky Spomky commented Sep 29, 2023

Target branch: 4.7.x
Resolves issue #468

  • It is a Bug fix
  • It is a New feature
  • Breaks BC
  • Includes Deprecations

@Spomky Spomky added this to the 4.7.2 milestone Sep 29, 2023
@Spomky Spomky self-assigned this Sep 29, 2023
@Spomky Spomky linked an issue Sep 29, 2023 that may be closed by this pull request
Parameter $repositoryClass of attribute class Doctrine\ORM\Mapping\Entity constructor expects class-string<Doctrine\ORM\EntityRepository<T of object>>|null, 'App\\Repository\\PublicKeyCredentialSourceRepository' given #468
Closed
@Spomky Spomky changed the base branch from 4.8.x to 4.7.x September 29, 2023 16:19
@sonarcloud
Copy link

sonarcloud bot commented Sep 29, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 12 Code Smells

76.5% 76.5% Coverage
7.1% 7.1% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@sonarcloud
Copy link

sonarcloud bot commented Sep 29, 2023

Please retry analysis of this Pull-Request directly on SonarCloud.

@sonarcloud
Copy link

sonarcloud bot commented Sep 29, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@sonarcloud
Copy link

sonarcloud bot commented Sep 29, 2023

Please retry analysis of this Pull-Request directly on SonarCloud.

@sonarcloud
Copy link

sonarcloud bot commented Sep 29, 2023

Please retry analysis of this Pull-Request directly on SonarCloud.

@sonarcloud
Copy link

sonarcloud bot commented Sep 29, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@Spomky Spomky merged commit 97763eb into 4.7.x Sep 29, 2023
17 of 19 checks passed
@Spomky Spomky deleted the bug/class-implement-missing branch September 29, 2023 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Spomky Spomky

Labels
None yet
Projects
None yet
Milestone
4.7.2
1 participant
@Spomky