Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround for Chrome 113 #251

Merged
merged 1 commit into from May 3, 2023
Merged

Workaround for Chrome 113 #251

merged 1 commit into from May 3, 2023

Conversation

metsma
Copy link
Contributor

@metsma metsma commented May 3, 2023

WE2-783

Signed-off-by: Raul Metsma raul@metsma.ee

@kristelmerilain kristelmerilain requested a review from mrts May 3, 2023 11:47
WE2-783

Signed-off-by: Raul Metsma <raul@metsma.ee>
@mrts mrts merged commit d9e5057 into web-eid:main May 3, 2023
9 checks passed
@martinpaljak
Copy link
Member

martinpaljak commented May 4, 2023

Having such random references to opaque internal issue trackers sort of defeats the spirit of open source (even if actual source is available). What is the reason? What is the dicussion? When was it reported?

@martinpaljak
Copy link
Member

martinpaljak commented May 4, 2023

I make a wild guess - it caught everyone by surprise yesterday. AFAIK there are folks on RIA payroll who could (SHOULD!) be running development/canary releases of the major browsers/operating systems (month+ reaction time) all the time to detect such things before they happen (and this is not the first time when issues like this seem to come as a "sudden surprise" when in fact it is just lack of proactivity).

(This is not a remark about ticket paricipants @metsma and @mrts who are fine gentlement doing their best. This is a complaint from a taxpayer to @web-eid (RIA) as an organization)

@kristelmerilain
Copy link
Contributor

All supported browsers Chrome, Edge and Firefox are tested on macOS, Ubuntu and Windows before and after the release of the new browser version.
The Chrome 113 version was also tested before it was made public. Unfortunately this issue did not come out during Chrome 113 beta testing and we discovered it yesterday when testing Chrome 113 released version.
We are currently actively working to make the new Web eID version public to users as soon as possible and we will certainly discuss internally how to avoid this kind of issues in the future.
We apologize for any inconvenience caused!

@mrts
Copy link
Member

mrts commented May 4, 2023

Kristel already explained the procedural side, let me also briefly explain the technical side (to answer "What is the reason?"). Chrome now directly launches the Native Host executable, rather than executing it via cmd.exe on Windows. As a consequence, the application window starts hidden (which is by design, it wasn't properly hidden before only because of the intermediate cmd.exe). This is explained in more detail in this mailing list post by Chrome developer Eric Lawrence. We actually had code for forcing the window to the foreground, but this is no longer sufficient to override the "start hidden" flag, hence the show-hide-show hack in this pull request.

@metsma metsma deleted the stable branch May 9, 2023 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants