Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Redefine AppInfo by PropsInfo #531

Merged
merged 1 commit into from Jul 27, 2022

Conversation

Rain120
Copy link
Contributor

@Rain120 Rain120 commented Jul 25, 2022

Motivation and Context

There has type error where had import @garfish/bridge-*, such as where dev/app-react-18/src/root.tsx:L6

What had I do

Bridge had define Props Info for an app info, but it will be meaningful which renamed be AppInfo than it, so I did to redefine to AppInfo

How Has This Been Tested

Reinstall and reopen dev/app-react-18/src/root.tsx:L6

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

…ningful which renamed be AppInfo than it, so I did to redefine to AppInfo
@vercel
Copy link

vercel bot commented Jul 25, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
garfish ✅ Ready (Inspect) Visit Preview Jul 25, 2022 at 9:38AM (UTC)

@codecov
Copy link

codecov bot commented Jul 25, 2022

Codecov Report

Merging #531 (75fa6ee) into main (c9f2b92) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #531   +/-   ##
=======================================
  Coverage   82.39%   82.39%           
=======================================
  Files          89       89           
  Lines       11923    11923           
  Branches     1817     1817           
=======================================
  Hits         9824     9824           
  Misses       2081     2081           
  Partials       18       18           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9f2b92...75fa6ee. Read the comment docs.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants