Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vm-sandbox): fix collect data exception #640

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

zhoushaw
Copy link
Member

Description

fix(vm-sandbox): fix collect data exception

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the documentation.

@vercel
Copy link

vercel bot commented Sep 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
garfish ✅ Ready (Inspect) Visit Preview Sep 18, 2023 11:28am

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


zhouxiao.shaw seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Patch coverage: 53.57% and project coverage change: -0.02% ⚠️

Comparison is base (9bc85ec) 83.34% compared to head (e323107) 83.32%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #640      +/-   ##
==========================================
- Coverage   83.34%   83.32%   -0.02%     
==========================================
  Files          90       90              
  Lines       12461    12459       -2     
  Branches     1932     1933       +1     
==========================================
- Hits        10385    10381       -4     
- Misses       2059     2061       +2     
  Partials       17       17              
Files Changed Coverage Δ
packages/browser-vm/src/modules/network.ts 79.13% <53.57%> (-2.07%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants