fix: change swc's jsc.parser.syntax with a reasonable value

web-infra-dev · Apr 24, 2023 · d69a2bf · d69a2bf
1 parent 2475217
commit d69a2bf
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 7 deletions.
diff --git a/packages/libuild-plugin-swc/src/es5.ts b/packages/libuild-plugin-swc/src/es5.ts
@@ -16,7 +16,7 @@ export const es5Plugin = (filename?: string | ((filename: string) => string)): L
             swcrc: false,
             configFile: false,
             extensions: {},
-            jsc: { target: 'es5' },
+            jsc: { target: 'es5', parser: { syntax: 'ecmascript' } },
             isModule: 'unknown',
           });
           const result = await swcCompiler.transformSync(name, chunk.contents.toString());

diff --git a/packages/libuild-plugin-swc/src/transform.ts b/packages/libuild-plugin-swc/src/transform.ts
@@ -22,6 +22,7 @@ export const swcTransformPlugin = (
       compiler.hooks.transform.tapPromise(pluginName, async (source): Promise<Source> => {
         const { originalFilePath } = resolvePathAndQuery(source.path);
         const { emitDecoratorMetadata = false, externalHelpers = false, pluginImport = [] } = options;
+        const isTs = source.loader === 'tsx' || source.loader === 'ts' || /\.tsx?$/i.test(originalFilePath);
         const enableTsx = source.loader === 'tsx' || source.loader === 'jsx' || /\.tsx$|\.jsx$/i.test(originalFilePath);
 
         // format is umd, disable swc-transform
@@ -40,11 +41,17 @@ export const swcTransformPlugin = (
             swcrc: false,
             configFile: false,
             jsc: {
-              parser: {
-                syntax: 'typescript',
-                tsx: enableTsx,
-                decorators: true,
-              },
+              parser: isTs
+                ? {
+                    syntax: 'typescript',
+                    tsx: enableTsx,
+                    decorators: true,
+                  }
+                : {
+                    syntax: 'ecmascript',
+                    jsx: enableTsx,
+                    decorators: true,
+                  },
               transform: {
                 react: {
                   runtime: jsx === 'transform' ? 'classic' : 'automatic',

diff --git a/packages/libuild-plugin-swc/src/umd.ts b/packages/libuild-plugin-swc/src/umd.ts
@@ -31,7 +31,7 @@ export const umdPlugin = (filename?: string | ((filename: string) => string)): L
             configFile: false,
             extensions: {},
             // transform by user-target
-            jsc: { target: getSwcTarget(compiler.config.target) },
+            jsc: { target: getSwcTarget(compiler.config.target), parser: { syntax: 'ecmascript' } },
             module: {
               type: 'umd',
             },