Merge pull request #21 from web-infra-dev/fix/useless-quote

fix: delete useless quote
web-infra-dev · Mar 4, 2024 · a6b3244 · a6b3244
2 parents b5bdc94 + adb7b8b
commit a6b3244
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/.github/workflows/CI.yml b/.github/workflows/CI.yml
@@ -100,7 +100,7 @@ jobs:
             target: "aarch64-pc-windows-msvc"
             build: pnpm build -- --target aarch64-pc-windows-msvc
 
-    name: stable - ${{ matrix.settings.target }} - node@14
+    name: stable - ${{ matrix.settings.target }} - node@16
     runs-on: ${{ matrix.settings.host }}
 
     steps:
@@ -109,7 +109,7 @@ jobs:
       - name: Setup node
         uses: actions/setup-node@v2
         with:
-          node-version: 14
+          node-version: 16
           check-latest: true
 
       - name: Install pnpm
@@ -126,13 +126,13 @@ jobs:
       - name: Cache cargo
         uses: Swatinem/rust-cache@v1
         with:
-          key: ${{ matrix.settings.target }}-node@14-cargo-cache
+          key: ${{ matrix.settings.target }}-node@16-cargo-cache
 
       - name: Cache NPM dependencies
         uses: actions/cache@v2
         with:
           path: ~/.pnpm-store
-          key: npm-cache-${{ matrix.settings.target }}-node@14-${{ hashFiles('pnpm-lock.yaml') }}
+          key: npm-cache-${{ matrix.settings.target }}-node@16-${{ hashFiles('pnpm-lock.yaml') }}
 
       - name: Pull latest image
         run: ${{ matrix.settings.docker }}

diff --git a/crates/utils/src/lib.rs b/crates/utils/src/lib.rs
@@ -15,7 +15,6 @@ pub fn extract_title_and_id(text_value: &str) -> (String, String) {
   } else {
     title.push_str(&text_value);
   }
-  title = title.replace("\"", "\\\"").replace("'", "\\\'");
   (title, custom_id)
 }
 
@@ -40,7 +39,7 @@ mod tests {
   #[test]
   fn test_extract_title_and_id_with_quotes() {
     let (title, custom_id) = extract_title_and_id("\"Hello' World\" {#id123}");
-    assert_eq!(title, "\\\"Hello\\' World\\\"");
+    assert_eq!(title, "\"Hello\' World\"");
     assert_eq!(custom_id, "id123");
   }
 }