test: the environment variables should be set correctly on the windows (

#5773)
web-infra-dev · May 27, 2024 · 251eca7 · 251eca7
1 parent 4079881
commit 251eca7
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 6 deletions.
diff --git a/tests/integration/deploy-csr/tests/index.test.ts b/tests/integration/deploy-csr/tests/index.test.ts
@@ -10,10 +10,14 @@ describe('deploy', () => {
   });
 
   test('support csr when deploy target is node', async () => {
-    await execa('MODERNJS_DEPLOY=node npx modern deploy -s', {
+    await execa('npx modern deploy -s', {
       shell: true,
       cwd: appDir,
       stdio: 'inherit',
+      env: {
+        ...process.env,
+        MODERNJS_DEPLOY: 'node',
+      },
     });
     const outputDirectory = path.join(appDir, '.output');
     const bootstrapJs = path.join(outputDirectory, 'index.js');
@@ -26,10 +30,14 @@ describe('deploy', () => {
   });
 
   test('support csr when deploy target is vercel', async () => {
-    await execa('MODERNJS_DEPLOY=vercel npx modern deploy -s', {
+    await execa('npx modern deploy -s', {
       shell: true,
       cwd: appDir,
       stdio: 'inherit',
+      env: {
+        ...process.env,
+        MODERNJS_DEPLOY: 'vercel',
+      },
     });
 
     const outputDirectory = path.join(appDir, '.vercel/output');
@@ -47,10 +55,14 @@ describe('deploy', () => {
   });
 
   test('support csr when deploy target is netlify', async () => {
-    await execa('MODERNJS_DEPLOY=netlify npx modern deploy -s', {
+    await execa('npx modern deploy -s', {
       shell: true,
       cwd: appDir,
       stdio: 'inherit',
+      env: {
+        ...process.env,
+        MODERNJS_DEPLOY: 'netlify',
+      },
     });
 
     const outputDirectory = path.join(appDir, 'dist');

diff --git a/tests/integration/deploy-server/tests/index.test.ts b/tests/integration/deploy-server/tests/index.test.ts
@@ -11,10 +11,14 @@ describe('deploy', () => {
   });
 
   test('support server when deploy target is node', async () => {
-    await execa('MODERNJS_DEPLOY=node npx modern deploy --skip-build', {
+    await execa('npx modern deploy --skip-build', {
       shell: true,
       cwd: appDir,
       stdio: 'inherit',
+      env: {
+        ...process.env,
+        MODERNJS_DEPLOY: 'node',
+      },
     });
     const outputDirectory = path.join(appDir, '.output');
     const staticDirectory = path.join(outputDirectory, 'static');
@@ -29,10 +33,14 @@ describe('deploy', () => {
   });
 
   test('support server when deploy target is vercel', async () => {
-    await execa('MODERNJS_DEPLOY=vercel npx modern deploy --skip-build', {
+    await execa('npx modern deploy --skip-build', {
       shell: true,
       cwd: appDir,
       stdio: 'inherit',
+      env: {
+        ...process.env,
+        MODERNJS_DEPLOY: 'vercel',
+      },
     });
 
     const outputDirectory = path.join(appDir, '.vercel/output');
@@ -59,10 +67,14 @@ describe('deploy', () => {
   });
 
   test('support server when deploy target is netlify', async () => {
-    await execa('MODERNJS_DEPLOY=netlify npx modern deploy --skip-build', {
+    await execa('npx modern deploy --skip-build', {
       shell: true,
       cwd: appDir,
       stdio: 'inherit',
+      env: {
+        ...process.env,
+        MODERNJS_DEPLOY: 'netlify',
+      },
     });
 
     const publishDir = path.join(appDir, 'dist');