fix(runtime): MODERN_TARGET is not injected when using Rspack (#3502)

web-infra-dev · Apr 20, 2023 · 28721cb · 28721cb
1 parent 0f087c4
commit 28721cb
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 17 deletions.
diff --git a/.changeset/six-tigers-own.md b/.changeset/six-tigers-own.md
@@ -0,0 +1,7 @@
+---
+'@modern-js/runtime': patch
+---
+
+fix(runtime): MODERN_TARGET is not injected when using Rspack
+
+fix(runtime): 修复 Rspack 模式未注入 MODERN_TARGET 的问题
diff --git a/packages/runtime/plugin-runtime/src/ssr/cli/index.ts b/packages/runtime/plugin-runtime/src/ssr/cli/index.ts
@@ -83,6 +83,12 @@ export default (): CliPlugin<AppTools> => ({
               '@modern-js/utils/ssr': require.resolve('@modern-js/utils/ssr'),
               '@modern-js/runtime/plugins': pluginsExportsUtils.getPath(),
             },
+            globalVars: (values, { target }) => {
+              values['process.env.MODERN_TARGET'] =
+                target === 'node' || target === 'service-worker'
+                  ? 'node'
+                  : 'browser';
+            },
           },
           tools: {
             webpackChain: (chain, { isServer, isServiceWorker, CHAIN_ID }) => {
@@ -102,23 +108,6 @@ export default (): CliPlugin<AppTools> => ({
                     { filename: LOADABLE_STATS_FILE },
                   ]);
               }
-
-              // add environment variables to determine the node/browser
-              const modernVars = {
-                [`process.env.MODERN_TARGET`]: JSON.stringify(
-                  isServer || isServiceWorker ? 'node' : 'browser',
-                ),
-              };
-              chain.plugin(CHAIN_ID.PLUGIN.DEFINE).tap(args => {
-                const [vars, ...rest] = args;
-                return [
-                  {
-                    ...vars,
-                    ...modernVars,
-                  },
-                  ...rest,
-                ];
-              });
             },
             babel: babelConfig,
           },