chore(server): remove useless server plugin hooks (#5099)

web-infra-dev · Dec 15, 2023 · 5782aa3 · 5782aa3
1 parent 3067256
commit 5782aa3
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 26 deletions.
diff --git a/.changeset/weak-pumas-guess.md b/.changeset/weak-pumas-guess.md
@@ -0,0 +1,8 @@
+---
+'@modern-js/server': patch
+'@modern-js/server-core': patch
+---
+
+chore(server): remove useless server plugin hooks (beforeDevServer & afterDevServer)
+
+chore(server): 移除无用的 server 插件钩子 (beforeDevServer 和 afterDevServer)
diff --git a/packages/server/core/src/plugin.ts b/packages/server/core/src/plugin.ts
@@ -91,12 +91,8 @@ const beforeServerInit = createAsyncWaterfall<ServerInitHookContext>();
 
 const afterServerInit = createAsyncWaterfall<ServerInitHookContext>();
 
-const beforeDevServer = createParallelWorkflow<ServerOptions, any>();
-
 const setupCompiler = createParallelWorkflow<Record<string, unknown>, any[]>();
 
-const afterDevServer = createParallelWorkflow<ServerOptions, any>();
-
 // TODO FIXME
 export type Route = Record<string, unknown>;
 const beforeRouteSet = createAsyncPipeline<Route[], Route[]>();
@@ -198,9 +194,7 @@ const serverHooks = {
   onApiChange,
   beforeServerInit,
   afterServerInit,
-  beforeDevServer,
   setupCompiler,
-  afterDevServer,
   beforeRouteSet,
   afterRouteSet,
   beforeProdServer,

diff --git a/packages/server/server/src/server/devServer.ts b/packages/server/server/src/server/devServer.ts
@@ -117,13 +117,13 @@ export class ModernDevServer extends ModernServer {
     const { befores, afters } = this.applySetupMiddlewares();
 
     // before dev handler
-    const beforeHandlers = await this.setupBeforeDevMiddleware();
+    const beforeHandlers = this.dev.before || [];
     this.addMiddlewareHandler([...beforeHandlers, ...befores]);
 
     await this.applyDefaultMiddlewares(app);
 
     // after dev handler
-    const afterHandlers = await this.setupAfterDevMiddleware();
+    const afterHandlers = this.dev.after || [];
 
     this.addMiddlewareHandler([...afters, ...afterHandlers]);
 
@@ -382,24 +382,6 @@ export class ModernDevServer extends ModernServer {
     };
   }
 
-  private async setupBeforeDevMiddleware() {
-    const { runner, conf, dev } = this;
-
-    const setupMids = dev.before || [];
-    const pluginMids = await runner.beforeDevServer(conf);
-
-    return [...setupMids, ...pluginMids].flat();
-  }
-
-  private async setupAfterDevMiddleware() {
-    const { runner, conf, dev } = this;
-
-    const setupMids = dev.after || [];
-    const pluginMids = await runner.afterDevServer(conf);
-
-    return [...pluginMids, ...setupMids].flat();
-  }
-
   private cleanSSRCache() {
     const { distDir } = this;
     const bundles = this.router.getBundles();