fix(storybook): fix typescript v5 capability issue (#4002)

web-infra-dev · Jun 19, 2023 · 580fcf7 · 580fcf7
1 parent 2858c11
commit 580fcf7
Show file tree

Hide file tree

Showing 4 changed files with 39 additions and 2 deletions.
diff --git a/.changeset/purple-dogs-know.md b/.changeset/purple-dogs-know.md
@@ -0,0 +1,8 @@
+---
+'@modern-js/plugin-storybook': patch
+---
+
+fix(storybook): fix typescript v5 capability issue
+
+fix(storybook): 修复与 typescript v5 的兼容问题
+
diff --git a/packages/cli/plugin-storybook/package.json b/packages/cli/plugin-storybook/package.json
@@ -60,12 +60,13 @@
     "@storybook/core": "6.5.12",
     "@storybook/manager-webpack5": "6.5.12",
     "@storybook/react": "6.5.12",
+    "@swc/helpers": "0.5.1",
     "esbuild": "0.15.7",
     "findup-sync": "^4.0.0",
     "fs-extra": "^10.0.0",
     "process.argv": "^0.6.0",
-    "tsconfig-paths-webpack-plugin": "4.0.0",
-    "@swc/helpers": "0.5.1"
+    "react-docgen-typescript-plugin": "1.0.5",
+    "tsconfig-paths-webpack-plugin": "4.0.0"
   },
   "devDependencies": {
     "@babel/core": "^7.21.8",

diff --git a/packages/cli/plugin-storybook/template/main.tmpl b/packages/cli/plugin-storybook/template/main.tmpl
@@ -43,6 +43,12 @@ module.exports = {
     },
     ...(userMainConfig.addons || []),
   ],
+  // Fix typescript v5 capability issue
+  // https://github.com/hipstersmoothie/react-docgen-typescript-plugin/issues/78
+  // https://github.com/storybookjs/storybook/issues/21642
+  typescript: {
+    reactDocgen: 'react-docgen-typescript-plugin'
+  },
   webpackFinal: async (config, options) => {
     // change webpack config
     const { customFinalWebpack = () => config } = options;

diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml