fix(builder): assetsRetry cause global variable pollution (#3989)

.changeset/tame-cougars-yawn.md

@@ -0,0 +1,8 @@
+---
+'@modern-js/builder-shared': patch
+---
+
+fix(builder): assetsRetry cause global variable pollution
+
+fix(builder): 修复 assetsRetry 污染全局变量的问题
+

packages/builder/builder-shared/package.json

@@ -137,6 +137,7 @@
   },
   "devDependencies": {
     "@babel/preset-env": "^7.21.5",
+    "@babel/preset-typescript": "^7.21.5",
     "@scripts/vitest-config": "workspace:*",
     "@types/babel__core": "^7.20.0",
     "@types/caniuse-lite": "^1.0.1",

packages/builder/builder-shared/scripts/postCompile.js

@@ -5,13 +5,12 @@ const { performance } = require('perf_hooks');
 
 async function compileRetryRuntime() {
   const { minify } = await import('terser');
-  const runtimeCode = await readFile(
-    path.join(__dirname, '../dist/runtime/assetsRetry.js'),
-    'utf8',
-  );
+  const source = path.join(__dirname, '../src/runtime/assetsRetry.ts');
+  const runtimeCode = await readFile(source, 'utf8');
   const distPath = path.join(__dirname, '../compiled/assetsRetry.js');
   const { code } = await transformAsync(runtimeCode, {
     presets: [
+      '@babel/preset-typescript',
       [
         '@babel/preset-env',
         {
@@ -20,6 +19,7 @@ async function compileRetryRuntime() {
         },
       ],
     ],
+    filename: source,
   });
   const { code: minifiedRuntimeCode } = await minify(
     {

packages/builder/builder-shared/src/plugins/AssetsRetryPlugin.ts

@@ -53,11 +53,9 @@ export class AssetsRetryPlugin implements WebpackPluginInstance {
     );
     const runtimeFilePath = getSharedPkgCompiledPath('assetsRetry.js');
     const runtimeCode = await fs.readFile(runtimeFilePath, 'utf-8');
-    // Runtime code will include `Object.defineProperty(exports,"__esModule",{value:!0})` after compiled by tsc
-    // So we inject `var exports={}` to avoid `exports is not defined` error
-    return `var exports={};${runtimeCode}init(${serialize(
+    return `(function(){${runtimeCode};init(${serialize(
       this.#retryOptions,
-    )})`;
+    )});})()`;
   }
 
   async getScriptPath() {

packages/builder/builder-shared/src/runtime/assetsRetry.ts

@@ -147,7 +147,7 @@ function reloadElementResource(
   }
 }
 
-export function retry(config: AssetsRetryOptions, e: Event) {
+function retry(config: AssetsRetryOptions, e: Event) {
   const targetInfo = validateTargetInfo(config, e);
   if (targetInfo === false) {
     return;