fix: add attributes for inline runtime script (#3987)

docs: change changeset
web-infra-dev · Jun 16, 2023 · 811ccd4 · 811ccd4
1 parent f08bbfc
commit 811ccd4
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 3 deletions.
diff --git a/.changeset/shaggy-tools-add.md b/.changeset/shaggy-tools-add.md
@@ -0,0 +1,6 @@
+---
+'@modern-js/builder-shared': patch
+---
+
+fix: add attributes for inline runtime script
+fix: 为 inline runtime 脚本添加属性
diff --git a/packages/builder/builder-shared/src/plugins/InlineChunkHtmlPlugin.ts b/packages/builder/builder-shared/src/plugins/InlineChunkHtmlPlugin.ts
@@ -90,9 +90,8 @@ export class InlineChunkHtmlPlugin {
     if (!(tag?.attributes.src && isString(tag.attributes.src))) {
       return tag;
     }
-    const scriptName = publicPath
-      ? tag.attributes.src.replace(publicPath, '')
-      : tag.attributes.src;
+    const { src, ...otherAttrs } = tag.attributes;
+    const scriptName = publicPath ? src.replace(publicPath, '') : src;
 
     if (!this.tests.some(test => test.exec(scriptName))) {
       return tag;
@@ -112,6 +111,9 @@ export class InlineChunkHtmlPlugin {
         publicPath,
         type: 'js',
       }),
+      attributes: {
+        ...otherAttrs,
+      },
       closeTag: true,
     };