-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(devServer): using current host and port to create HMR connection #3445
feat(devServer): using current host and port to create HMR connection #3445
Conversation
🦋 Changeset detectedLatest commit: 9f31558 The changes in this PR will be included in the next version bump. This PR includes changesets to release 213 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #3445 +/- ##
==========================================
+ Coverage 57.59% 57.95% +0.35%
==========================================
Files 672 668 -4
Lines 17794 17725 -69
Branches 3876 3855 -21
==========================================
+ Hits 10249 10272 +23
+ Misses 6934 6846 -88
+ Partials 611 607 -4
... and 76 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Summary
Make default behavior consistent with rspack-cli / webpack-cli / vite.
🤖 Generated by Copilot at 1942edf
This pull request improves the HMR (hot module replacement) feature of the
modern.js
framework by making thedevServer.client
configuration more flexible and consistent. It updates the code in theserver
package to use the current host and port of the page for the HMR connection by default. It also updates the documentation in thebuilder-doc
package for both English and Chinese languages, with examples and tips for different scenarios. It adds a changeset file to record the changes for the next release.Details
🤖 Generated by Copilot at 1942edf
devServer.client
configuration in thebuilder-doc
andserver
packages to use the current host and port of the page for the HMR connection by default (link, link, link, link, link, link, link, link, link)devServer.client
configuration in theguide/advanced/hmr
pages to explain how to handle proxying an online page to local development (link, link)Related Issue
Checklist
pnpm run change
.