Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(doc-e2e): add doc-tools e2e #3472

Merged
merged 2 commits into from Apr 18, 2023
Merged

feat(doc-e2e): add doc-tools e2e #3472

merged 2 commits into from Apr 18, 2023

Conversation

sanyuan0704
Copy link
Collaborator

@sanyuan0704 sanyuan0704 commented Apr 18, 2023

Summary

🤖 Generated by Copilot at 19c4b5a

This pull request adds e2e tests for the doc-tools plugin of the modern.js framework. It creates two fixtures, one for the base doc functionality and one for the i18n support, and uses puppeteer and modernTestUtils to verify the rendering and behavior of the doc pages. It also improves the TypeScript code and the CSS styling of the appearance switch button in the SwitchAppearance component. It updates the @modern-js/doc-core package and adds a changeset file for the release workflow.

Details

🤖 Generated by Copilot at 19c4b5a

  • Add doc-tools e2e tests for base and i18n fixtures (F4-F19)
    • Add modern-sidebar and modern-nav-appearance classes to the corresponding elements (link, link)
    • Remove unnecessary non-null assertion operator from setTheme function call (link)

Related Issue

Checklist

  • I have added changeset via pnpm run change.
  • I have updated the documentation.
  • I have added tests to cover my changes.

@changeset-bot
Copy link

changeset-bot bot commented Apr 18, 2023

🦋 Changeset detected

Latest commit: ede4f72

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Apr 18, 2023

Codecov Report

Patch coverage: 74.78% and project coverage change: +0.69 🎉

Comparison is base (99693f0) 57.59% compared to head (ede4f72) 58.29%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3472      +/-   ##
==========================================
+ Coverage   57.59%   58.29%   +0.69%     
==========================================
  Files         672      670       -2     
  Lines       17794    17773      -21     
  Branches     3876     3867       -9     
==========================================
+ Hits        10249    10360     +111     
+ Misses       6934     6808     -126     
+ Partials      611      605       -6     
Impacted Files Coverage Δ
packages/cli/core/src/nodeApi.ts 0.00% <ø> (ø)
packages/cli/doc-plugin-auto-sidebar/src/index.ts 0.00% <0.00%> (ø)
...s/cli/plugin-changeset/src/commands/releaseNote.ts 36.95% <0.00%> (ø)
packages/cli/plugin-changeset/src/utils/index.ts 100.00% <ø> (ø)
packages/cli/core/src/createCli.ts 72.00% <72.00%> (ø)
packages/cli/plugin-data-loader/src/cli/loader.ts 81.81% <83.33%> (ø)
packages/cli/core/src/config/loadConfig.ts 83.33% <85.71%> (+0.25%) ⬆️
packages/cli/core/src/utils/initAppDir.ts 88.88% <88.88%> (ø)
packages/cli/core/src/index.ts 71.42% <100.00%> (-0.62%) ⬇️
packages/cli/core/src/types/index.ts 100.00% <100.00%> (ø)
... and 4 more

... and 91 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sanyuan0704 sanyuan0704 merged commit d27fae0 into main Apr 18, 2023
7 checks passed
@sanyuan0704 sanyuan0704 deleted the feat/doc-tools-e2e branch April 18, 2023 04:06
This was referenced Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants