Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cli): improve commands descriptions #3473

Merged
merged 1 commit into from Apr 18, 2023

Conversation

chenjiahan
Copy link
Member

@chenjiahan chenjiahan commented Apr 18, 2023

Summary

🤖 Generated by Copilot at ec4cb53

This pull request improves the descriptions and messages of various commands and generators in the web-infra-dev/modern.js repository. It makes them more consistent, clear, and informative for both English and Chinese users.

Details

🤖 Generated by Copilot at ec4cb53

  • Add a changeset file to specify the affected packages and versions (link)
  • Improve the descriptions of the commands in the app-tools, doc-tools, module-tools, and plugin-lint packages for English and Chinese users (link, link, link, link, link, link, link, link, link, link, link)
  • Improve the descriptions of the commands in the main-doc and module-doc packages for English and Chinese users (link, link, link, link, link, link)
  • Improve the success messages of the doc-generator, module-generator, monorepo-generator, and mwa-generator packages for English and Chinese users (link, link, link, link, link, link, link, link)
  • Update the README template of the mwa-generator package to use "Modern.js App" as the title (link)

Related Issue

Checklist

  • I have added changeset via pnpm run change.
  • I have updated the documentation.
  • I have added tests to cover my changes.

@changeset-bot
Copy link

changeset-bot bot commented Apr 18, 2023

🦋 Changeset detected

Latest commit: ec4cb53

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Apr 18, 2023

Codecov Report

Patch coverage: 73.78% and project coverage change: +0.69 🎉

Comparison is base (99693f0) 57.59% compared to head (ec4cb53) 58.29%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3473      +/-   ##
==========================================
+ Coverage   57.59%   58.29%   +0.69%     
==========================================
  Files         672      670       -2     
  Lines       17794    17773      -21     
  Branches     3876     3867       -9     
==========================================
+ Hits        10249    10360     +111     
+ Misses       6934     6808     -126     
+ Partials      611      605       -6     
Impacted Files Coverage Δ
packages/cli/core/src/nodeApi.ts 0.00% <ø> (ø)
packages/cli/doc-plugin-auto-sidebar/src/index.ts 0.00% <0.00%> (ø)
...s/cli/plugin-changeset/src/commands/releaseNote.ts 36.95% <0.00%> (ø)
packages/cli/plugin-changeset/src/utils/index.ts 100.00% <ø> (ø)
packages/cli/core/src/createCli.ts 72.00% <72.00%> (ø)
packages/cli/core/src/config/loadConfig.ts 83.33% <85.71%> (+0.25%) ⬆️
packages/cli/core/src/utils/initAppDir.ts 88.88% <88.88%> (ø)
packages/cli/core/src/index.ts 71.42% <100.00%> (-0.62%) ⬇️
packages/cli/core/src/types/index.ts 100.00% <100.00%> (ø)
packages/cli/core/src/utils/index.ts 100.00% <100.00%> (ø)
... and 3 more

... and 92 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@chenjiahan chenjiahan merged commit 432ac8b into web-infra-dev:main Apr 18, 2023
8 checks passed
@chenjiahan chenjiahan deleted the commands_desc_0418 branch April 18, 2023 06:30
This was referenced Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants